About Icaros

[Xanashi]

Sorry for the short absence, everyone, it's been a busy weekend.

@Lenmaer
I have tried to completely replicate your scenario. I started out by disabling Icaros,
then I constructed a folder "tree" using the same folder names as in the filepath you wrote.
I then added files with the same filename as in your example, plus a couple of files with both longer and shorter filenames.
I made sure some of the files with long names, was header stripped.

But in the end, after I re-activated Icaros, all the files thumbnailed fine.
Are you sure the folder didn't just require a refresh? :-)

Edit: I spoke too soon. Had forgotten the "[Yousei-raws] Eiyuu Densetsu - Sora no Kiseki The Animation" sub-directory.
Incidentally, after adding that directory and trying to move the files, Explorer threw an exception stating that the filename was
about to exceed it's maximum length, and automatically canceled the move operation.

How exactly did you create such a long filepath? :-)

@BitTech
Well, header stripping has nothing to do with "Content ID" either ("Content Compression" would have been closer),
but point taken, I agree that the Video Compression field would be a better fit for the "Format (Level)" string.
I will make the switch before 2.0 reaches final.

@Paladin77
Welcome back :-)
I had a feeling the new changes would be to your liking.
And also good to know that 2.0 worked on your machine.
As always, thanks for the feedback! ;-)

@cengizhan
There's no doubt that this problem is caused by a corrupt container.
Unfortunately the only way for me to fix the hang is by having a sample of the corrupt file.
Would it be possible for you to cut a sample of the original file?
If you don't have a binary cutter, I can provide you with one.

@All
I'm almost done modifying the installer, so it should be capable of performing upgrades. It will be posted soon.
I have only had little time to work on the logging implementation for debug builds of Icaros,
and it proved a bit more difficult than I had initially hoped.
I'll get back with more info soon.

[cengizhan]

I had accidentally deleted original file.

Isn't there any way to skip corrupted files? Why does explorer insists on broken files?

[Xanashi]

(03-19-2012 08:09 AM)cengizhan Wrote:  I had accidentally deleted original file.

Isn't there any way to skip corrupted files? Why does explorer insists on broken files?

Too bad.
There could be many causes. Depends on, in what way the file is corrupt.
Most corrupted files should already be skipped automatically, but as you have just witnessed,
it is impossible for me to foresee all possible deviations.

Samples are always the best way to eliminate such 'bugs'.
In the end, the file should still be remuxed, so playback doesn't suffer as well.

[cengizhan]

Here is bad sample : http://dl.dropbox.com/u/57867163/3.mkv.001

[Lenmaer]

(03-19-2012 07:13 AM)Xanashi Wrote:  @Lenmaer
I have tried to completely replicate your scenario. I started out by disabling Icaros,
then I constructed a folder "tree" using the same folder names as in the filepath you wrote.
I then added files with the same filename as in your example, plus a couple of files with both longer and shorter filenames.
I made sure some of the files with long names, was header stripped.

But in the end, after I re-activated Icaros, all the files thumbnailed fine.
Are you sure the folder didn't just require a refresh? :-)

Edit: I spoke too soon. Had forgotten the "[Yousei-raws] Eiyuu Densetsu - Sora no Kiseki The Animation" sub-directory.
Incidentally, after adding that directory and trying to move the files, Explorer threw an exception stating that the filename was
about to exceed it's maximum length, and automatically canceled the move operation.
I've folder names that can be up to 3 times that long on my pc, if I count in the sub folders.

How exactly did you create such a long filepath? :-)

I just moved the folders, one into another.
But for me, explorer never bugged me with filenames exceeding their maximum length. Only some software do.
I've folder paths than can be up to 3 times that long on my PC (sub-folders included).

[Xanashi]

(03-20-2012 07:14 AM)Lenmaer Wrote:  I just moved the folders, one into another.
But for me, explorer never bugged me with filenames exceeding their maximum length. Only some software do.

Hmm...

I'm not sure how to fix this since Explorer doesn't allow me to create such long paths.
Can anyone else reproduce this issue?

Btw Lenmaer, I have a new beta ready that allows upgrading from any previous version.
I was a bit ambivalent about the whole restart procedure, so I decided to make it similar to the uninstall procedure, i.e. let the user decide what action to take.

Icaros 2.0 Beta 3: [A newer version has been posted]

(As usual the previous links will be updated as well. Portable version remains the same, since the changes only concern the installer.)

@cengizhan
Thanks for the sample ^_^

The only problem I had with that sample was that it generated a kind of distorted thumbnail.
The cause was again container related, it seems. Remuxing the file fixed it.
FFmpeg apparently had trouble parsing some of the wrongly muxed headers after a seek.
Not something I can do much about, though.

[Lenmaer]

I like the new installer, works great. Thumbnails are still generating and fast as well.
I approve it. ^^

As for the bug, you shouldn't bother too much on that one, it's really a trivial one. I just wanted to inform you that it may occur. Also it's probably a FFmpeg limitation as the native windows thumbnail generator still works (if icaros is disabled).

[Shiro]

I just registered to say thanks Xanashi for your great Thumbnailer program. Not long ago I was against mkv ordered chapters due to no thumbnailing of those files on windows but now your program thumbnails almost everything. Thanks again!

I also have problems with Icaros 2.0 (beta 1 and 2) so I tested in plenty of computers so far and these are the results:

Windows Vista SP2 32bits -> It doesn't work.

Windows 7 SP1 32 bits -> It doesn't work.

Windows 7 SP1 x64 -> Works and fast!

Windows 8 Consumer Preview 32bits -> It doesn't work.

Windows 8 Consumer Preview x64 -> It doesn't work.

Some observations: It just doesn't work on Windows 8. Probably because the OS has .Net Framework 4.5 beta included and maybe something changed for shell extensions.
Also it doesn't work with 32 bits OS (Icaros 1.3.2 works). I can see with ProcessExplorer the ThumbnailProvider is loaded in explorer.exe but it does nothing. Maybe the problem is on the ffmpeg dlls or the way they are compiled? Should I try compiling your ffmpeg sources and see if it works?

[Xanashi]

@Lenmaer
Great! ^_^

If I can get to reproduce it at some point, I will certainly try to find a way to fix it.
And you're most likely right about it being an limitation of FFmpeg. Could definitely be a possibility.

@Shiro
Thank you for this very comprehensive report.

Your test results are very interesting, only Windows 7 SP1 x64 is working.
I have personally tested on two different machines with Win7 x64 SP1 and a VM with Win7 x86 SP1.
Shark has also very kindly helped by testing on the following systems:

Vista (SP2?) x64,
Win7 SP1 x86,
Win7 SP1 x64,
Win8 CP x64.

All on different machines or partitions.
Icaros 2.0 worked successfully on all systems for both Shark and I.

This lead me to believe there is either a conflict with FFmpeg and some other software,
or perhaps that my configuration setup of FFmpeg is not complete.

If you have any experience with compiling FFmpeg, then please go ahead, it might work :-)

Also, I don't know if you use the installer or the portable version, but in case you use the portable,
be sure to install .NET 4 Client before testing Icaros. (I assume you have, since IcarosConfig wouldn't allow otherwise).
And make sure that you do not use beta 1 for any testing.

If you have time and can PM me your E-mail, I can also offer some debug builds,
that might help us get to the bottom of this.

I really appreciate the feedback. ^_^

[Shiro]

Thanks Xanashi! I send to you a PM.

If I have time I'll try to compiling the ffmpeg sources. I already compiled LAvfilters once so it shouldn't be a problem.